Add support for v1_inputs to v2-style exec :) #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NHDaly
force-pushed
the
nhd-v2-txns-inputs
branch
from
a7103c8 to
8d7a12f
Compare
NHDaly
added a commit
that referenced
this pull request
Mar 31, 2022
) * Support v2 "async" transactions returning multipart Arrow responses Part 1: WIP basic GET/PUT calls for the v2 API. * Parse the MultiPartForms + Arrow results into Arrow.Tables[] * Add tests for v2 async/sync responses * Update src/api.jl * Add support for v1_inputs to v2-style exec :) (#23) * Add support for v1_inputs to v2-style exec :) * Adjust to latest /problems endpoint implementation from frontend * Better comment + version patch on parse_multipart_form * clarify test * Rename exec to exec_async * Fixups: - support empty responses - export the new names - add an "is finished" function * Delete the struct ResultPhysicalRelation, and just return a pair * prefer haskey * Switch back to returning a Dict, since i think it's more normal. * Add examples/exec_async.jl: ```bash $ julia --proj examples/exec_async.jl "nhd-test-1" "nhd-s" "def x = 1 def x = x+1 def output = x" Transaction is created... JSON3.Object{Vector{UInt8}, Vector{UInt64}} with 2 entries: :id => "c616a8ae-3be2-0d51-fb0e-b7f862bc367d" :state => "CREATED" ``` * Fix bug in transaction_is_done after switching to dicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges into #17 .