Fix closed issue dashboard state summaries#55
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates durable tracked-issue summaries to correctly reflect issues that have transitioned to Closed, ensuring both the dashboard (/) and state API (/api/v1/state) remain accurate even after issues leave the active polling set.
Changes:
- Refreshes persisted tracked-issue cache state via per-tick orchestration updates.
- Renders tracked-issue dashboard rows using cached state (instead of hardcoding
Open). - Adds integration regressions covering orchestration refresh,
/api/v1/statedistribution, and dashboard JS rendering, plus a user guide note.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Symphony.Integration.Tests/OrchestrationTickServiceTests.cs | Adds an integration test + harness helper to verify cached issue state refreshes to Closed. |
| tests/Symphony.Integration.Tests/ApiSmokeTests.cs | Adds smoke coverage for /api/v1/state tracked distribution including Closed, plus dashboard JS regression assertions. |
| src/Symphony.Host/wwwroot/assets/dashboard.js | Uses issue.state from cached tracker state for tracked issue rendering (removes hardcoded Open). |
| src/Symphony.Host/Services/OrchestrationTickService.Persistence.cs | Introduces persisted cache “state refresh” routine for previously seen issues. |
| src/Symphony.Host/Services/OrchestrationTickService.cs | Invokes tracked issue cache state refresh during ticks when tracker access is valid. |
| docs/UserGuide.md | Documents that tracked issue summaries refresh cached GitHub states so Closed counts persist. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closedin the durable dashboard/API summariesOpenTesting
Spec
/)/api/v1/*)Closes #54