fix(mac): respect get_logs payload limit instead of hardcoding 50#49
Open
Relevant47 wants to merge 1 commit into
Open
fix(mac): respect get_logs payload limit instead of hardcoding 50#49Relevant47 wants to merge 1 commit into
Relevant47 wants to merge 1 commit into
Conversation
The macOS IPC handler had a comment claiming it would extract `limit` from the payload, but the next line discarded `req` and hardcoded `let limit = 50`. Mirror the Windows handler (and the pattern already used by `handleGetParentAudit`) so callers requesting more or fewer logs get what they asked for, restoring platform parity with `shared/protocol.ts` and `IpcPipeService.cs`. Fixes #48
✅ Deploy Preview for focuslock-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The macOS
handleGetLogshad a misleading// Extract limit from payload if presentcomment but the next line hardcodedlet limit = 50and threw awayreq. The Windows daemon already reads the payload'slimit. This brings the platforms back in line withshared/protocol.ts'sget_logsshape.Files changed
daemon-mac/Sources/FocusLockDaemon/IpcSocketService.swift— readlimitfromreq.payloadusing the same[String: AnyCodable]pattern thathandleGetParentAuditalready uses one function below (line 413).Fixes #48
Risk tier
Trivial / single-file → normal PR, ready for review.
handleGetParentAudit).limit(or sends a non-int),limitstays at 50, matching today's behavior.{ limit: N }— Windows returns N rows; macOS now does too.Verification
swift build -c releaseis the real gate.IpcPipeService.cs:304-311confirms equivalent semantics.🤖 Generated with Claude Code
Generated by Claude Code