feat: add support for feed recommendation #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhdk
requested changes
Oct 21, 2025
Contributor
brianhdk
left a comment
brianhdk
left a comment
There was a problem hiding this comment.
For now I'll just request changes, to remove myself, until the PR is again ready for review.
brianhdk
approved these changes
Nov 6, 2025
Contributor
brianhdk
left a comment
brianhdk
left a comment
There was a problem hiding this comment.
Looks really good to me - only concern is the naming of the method - it's a bit verbose IMHO. But regardless, I don't need to see it again.
| } | ||
| }); | ||
|
|
||
| const result = await recommender.recommendFeedRecommendationInitialization(request.build()); |
Contributor
There was a problem hiding this comment.
My only though is about the naming of this method - it's a bit verbose - especially since it has the Recommend -word twice. What do you think?
Collaborator
Author
There was a problem hiding this comment.
Yeah I have removed recommendation from inside the name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/B1dmyiBo/12183-feed-update-sdks-at-least-js-ts-with-the-new-apis-and-datamodels-introduced-in-feed