Define explicit expected values in filter variable replacement tests #562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
testReplaceFilterVariablesdeterministic by defining expected options and values per case instead of deriving them via reflection.%...%filter patterns and formats.Description
tests/Service/VariableServiceTest.phpwith a data providerreplaceFilterVariablesProviderthat supplies explicit expected options and values.expectedStartTimestampandexpectedQuarterRangeto compute expected timestamps and quarter ranges for provider cases.testReplaceFilterVariablessignature to accept the expected option and expected value and assert the service output against those values.CHANGELOG.mddocumenting the extended filter variable replacement tests.Testing
tests/Service/VariableServiceTest.phpand can be run withvendor/bin/phpunit tests/Service/VariableServiceTest.phpif desired.Codex Task