Bug: Package update might be broken?

[fuzzything44]

Describe the Bug
Getting 401 Unauthorized when attempting to publish new versions of packages, even while using the same API key. This had been previously working with no changes on our end, so it's likely related to your server maintenance 3 days ago? Another modder I've talked with is also having this issue, and is using a different API key than me.

To Reproduce
Steps to reproduce the behaviour:

1. Publish a package
2. Attempt to update package with dotnet nuget push -s ReloadedRepo -k $apiKey $nugetFile.FullName (see our publish script here https://github.com/NotNite/RNSReloaded/blob/main/publish.ps1)

Expected Behaviour
The package is updated

Additional Context
Example GH workflow: https://github.com/NotNite/RNSReloaded/actions/runs/22001506775/job/63575044223

[Sewer56]

@fuzzything44 Thanks for letting me know, I just woke up, will look into it in a sec.

I did a pretty big update on Monday, yeah. I rebased all my changes from 4 year old BaGet (no longer maintained), to the newer BaGetter (fork).

The service that was running was fairly unresponsive, at least on the WebUI, and constantly kept throwing SQLite related query error behind the scenes. Rather than investigating, I opted on spending a full day rebasing.

Unlike the old days, I did actually add unit tests for the new functionality this time around; but if it's not working in production then I clearly missed something.

[Sewer56]

@fuzzything44
I've spent around 2 hours doing an audit of the code.
A fix should be live, I got actual integration tests for this now.

Rebase process was a bit more involved than usual, between the entire project being renamed (BaGet -> BaGetter); small extra fixes required to adapt to upstream changes, and some miscellany like bagetter/BaGetter#264 (comment)

I used an LLM to get the initial port done [saved a lot of time]. Essentially 6 sequential sessions, with own plan->review->code->review->commit loops. Then I took that, reviewed it thoroughly, did some extra manual by hand cleanups; and amended the commits. Part of that work was also grouping/squashing commits. On the old branch I had a lot of tiny tweak/fix commits; but that increases commit count, which complicates rebasing.

Now I have 1 proper commit per feature/meaningful change. That should not only make it easier to audit, but also easier to rebase in the future; as it's unlikely I'll be done with R3 within the next 2 years or so.

In any case, the code that was there worked; but it seems that along the way, I didn't catch that PackagePublishController was not updated; and there weren't integration tests for that. So while the API Key check code was all there, and unit tested for all the cases (master key, allowed keys, package keys); the code to extract the ApiKey from the existing package at the endpoint was missing, so I was never actually validating against the package key; only master and allowed keys.

That's kind of my bad. Despite still being thorough, I may have rushed a little.

To be more specific, seems that in my scramble to get this running due to bagetter/BaGetter#264 (comment) , (both locally and on server) I forgot to test the actual API afterwards in the process. 😅

[fuzzything44]

Looks like it's working for both me and the other modder who I knew had this issue! Thanks for the quick fix