Trim lines when reading mrt note to deal with extra spaces#7
Merged
Reloe merged 1 commit intoReloe:mainfrom Jul 29, 2025
Merged
Trim lines when reading mrt note to deal with extra spaces#7Reloe merged 1 commit intoReloe:mainfrom
Reloe merged 1 commit intoReloe:mainfrom
Conversation
Author
|
Oops just realized auto-formatter hit a bunch of random lines (extra spaces at the end of lines funnily enough), I can remove if it's problematic, only important change is line added line 113 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for extra space breaking everything. For example, having a note like:
will not work, because of the extra space after
intstart. The idea here is to trim every line (instead of just the note, as is done on line 111) to resolve all such issue.Another solution would be to instead match "intstart" and "intend", but not really sure how efficient that is in LUA / went with easier solution.