Conversation
Relorer
requested changes
Apr 14, 2023
| androidAudioFocusGainType: AndroidAudioFocusGainType.gainTransient)); | ||
|
|
||
| return TTSController(session); | ||
| List<Object?> voices = await FlutterTts().getVoices; |
Owner
There was a problem hiding this comment.
уже вот в этом месте должна быть фильтрация по локали и типизация в конкретный тип, чтобы в списке были только en не null озвучки в конкретном типе без необходимости обращения через [""]
Owner
There was a problem hiding this comment.
- пусть это будет сразу мапа - где название озвучики - ключ а значение - другая мапа которую может принимать библиотека tts
Map<String, String> voiceMap = {
"name": (voice as Map)["name"],
"locale": (voice)["locale"]
};
| selectedVoice = value; | ||
| }); | ||
| getIt<SettingsController>().setVoice(value); | ||
| getIt<TTSController>().setVoice(value); |
| } | ||
|
|
||
| void speak(String text) async { | ||
| setVoice(settingsController.voice); |
Owner
There was a problem hiding this comment.
добавить поле-кэшь с последним значением озвучки, чтобы вызывать setVoice только если настройки изменились
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.