Thick text buttons (lag issue)

[Ristellise]

[Ristellise]

With remotetech

Without remotetech

[markus-k]

Commenting out all the code in ModuleSPU.HookPartMenus() seems to resolve this issue, but removes functionality of course. it looks to me like its rendering the text on top of each other, creating thousands of layers which slows the game down...

[SirDiazo]

Looks like something went odd here.:

RemoteTech/src/RemoteTech/Modules/ModuleSPU.cs

Line 130 in 1de1136

HookPartMenus();

That line is calling the HookPartMenus() method every FixedUpdate frame for some reason.

[Peppie84]

Hi,
@markus-k i get the same results. The last two days i tried to figure out why this happens but without success :/ My last comment on our team chat was:

i think the setValue on the BaseEvent is not updating the current item, it "creates" a new item at the same position ...

and this will also cause the lag.

@SirDiazo i also tried to call the HookPartMenus() once for each "context menue", but also without success. No one from the RemoteTechCrew changed this part of code, i think Squad changed something on the UIPartActionWindow or UIPartActionItem or BaseEvent

Any idea what we can do?

Edit: @JDPKSP , @NathanKell , @pjf , @erendrake

[SirDiazo]

If I had to guess? (And it's a total guess) I'd start with UIPartActionWindow.

I don't really know the UIPartActionWindow or UIPartActionItem classes, but the BaseEvent class is what the [KSPEvent] attribute creates, I cant' see how that would tie into what (I think) is ultimately a GUI issue.

(I cant' actually help with this issue, HookPartMenus() uses a couple code things I have not worked with before and don't understand.)

[Ristellise]

I would also comment. I think science parts also are affected.

[cybercritic]

Moving the HookPartMenus(); from FixedUpdate in ModuleSPU.cs to OnStart seems to fix the issue.

[Ristellise]

Bump.
@peppie23did you see what cybercritic said? Is it possible?

[Peppie84]

Hi,

the idea of cybercritic would only fix the lag and the "thick text" issue but we'll loose the ability for time delayed actions. We can only hook the action buttons on the context menue from the FixedUpdate method. I've also tried to hook the menue via the GameEvents.onPartActionUICreate-event but the issue is still there.

It "looks like" that the eventField.setValue() always creates a new object. If i count the elements of the context menue it will increase for each HookPartMenus() call.

What i've also tried:

• remove the original ActionItem and insert a new one to the list = without success
• calling the UIPartActionWindow.Update() after changing the ActionItem = without success
• calling the UIPartActionItem.Update() after changing the ActionItem = without success
• changing the label of the original ActionItem to string.empty = without success
• formatting c:\ = without success
• and many many other things = without success

[zeroinformatique]

I figured something out. As soon as there's a Mechjeb part, or a probe part on your vessel, the bug occurs.
If it's a vessel with only Kerbals, the bug doesn't occur. It must be a problem with the Flight-computer ?
Edit: I tried to put a probe part on a vessel, and eject it with a decoupler. As soon as the probe is ejected, the bug disappears.

[Ristellise]

Hmm i tested on probe cores but not kerbals...
however the this is still there :P and is a lag to those who have a pre release Version.