Skip to content

Conversation

@Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Jun 5, 2014

Travis CI seems to be stable, PR to move it into the develop branch.

Pezmc and others added 19 commits June 2, 2014 10:53
Use a passworded zip for the dll's

Not entirely sure where to document the password
Travis should now set the environment variable ZIPPASSWORD which can
then be used to unzip the .dll's

I believe this doesn't work with pull requests, as in theory a pull
request could just dump env to access the password.
+ Correct mistake in travis.yml
+ Remove Travis deploy

Our custom tagging was causing this to trigger.
We can just rely on the custom solution for now!

+ Catch branches with /'s in their name as that's not a valid filename
Add automatic github deploys
If we're already on a build tag, we don't need to do anything.
Enhancements to travis release system, hopefully travis should test this merge.
Include information about the build in the release notes and in the
zip. This way we can confirm what build people have downloaded.
Include build information in build zip
@erendrake
Copy link
Member

are there any issues or strangeness we need to know about for moving it to develop? Have you hardcoded the branch in anywhere and we will have to change it?

After reviewing, looks good to me.

@Starstrider42
Copy link
Contributor

This might be OT, but how did you get GitHub to display

All is well — The Travis CI build passed · Details

@Pezmc
Copy link
Contributor Author

Pezmc commented Jun 5, 2014

It's not coupled to branches at all, just this repo, as it uses the branch that the commit was posted to.

@Starstrider42 it's part of the github build API, travis is set to build the pull requests and then update github with their status.

Pezmc added a commit that referenced this pull request Jun 5, 2014
Move travis ci intergration into the develop branch
@Pezmc Pezmc merged commit ef0afd0 into develop Jun 5, 2014
@Starstrider42 Starstrider42 deleted the chore/travis branch October 4, 2014 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants