Improvements to Python 3.7 and testing infrastructure#3
Merged
tombasche merged 2 commits intoRepositPower:masterfrom Oct 14, 2018
Merged
Improvements to Python 3.7 and testing infrastructure#3tombasche merged 2 commits intoRepositPower:masterfrom
tombasche merged 2 commits intoRepositPower:masterfrom
Conversation
Python 3.7 final has been released [0]. Re-add this to continuous integration testing, and note the support level in setup.py for PyPI and other packagers. Note: Travis-CI's support for Python 3.7 and communication around it is less than ideal. A Travis-CI representative recently provided comment on their "official" workaround [1], for users who need to meet Python 3.7's dependencies, yet aren't ready to move their entire testing image to Ubuntu Xenial (16.04) from default Ubuntu Trusty (14.04) at this stage. See further comments at [2]. [0] https://www.python.org/downloads/release/python-370/ [1] travis-ci/travis-ci#9069 (comment) [2] travis-ci/travis-ci#9815
setuptools in setup.py reports Python 2.7 and Python 3.4-3.7 (inclusive) support. Conform the python version testing in Travis CI to match each of these versions, as good practice to avoid future conflicts or regressions.
Echelon9
force-pushed
the
feature/python3.7
branch
from
9d0a5d0 to
0cc2c78
Compare
Contributor
Author
|
The CI failures with "pipenv install" appear to be due to a recent, unrelated bug in pipenv that was fixed in the last couple of days: pypa/pipenv#2954 |
Contributor
Author
|
Thanks @tombasche |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a great Python library, thanks @RepositPower and @tombasche! It's also fantastic that you've released this as an open source client library for your energytech system.
I noticed two small potential improvements around Python version support, packaging and testing. Please let me know of any comments you'd like reflected in this PR.