Conversation
ghillairet
approved these changes
Aug 3, 2017
Member
ghillairet
left a comment
There was a problem hiding this comment.
Passed QA, works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes classloader issue described in #293 by using Orbit Jackson and eliminating import-package in MANIFEST.MF
We were previously using Jackson from the RepreZen bundles plugin. I removed it from there and added Tycho-friendly Jackson from Eclipse Orbit
How to QA
A followed the steps from here
To check that the reported classpath problem is present in old builds:
4. Install KaiZen OpenAPI Editor from this update site: http://products-internal.reprezen.com/swagedit/0.8.0.201707202032. This is the latest update site which uses Jackson from RepreZen bundles.
Open a Swagger file - the editor will not be opened, Eclipse will show an error dialog.
To check that the new build fixes it:
5. Get the same Eclipse+Docker Tools + STS plugins configuration by uninstalling KaiZen editor.
6. Install KaiZen Editor using this update site: http://products-internal.reprezen.com/swagedit/0.8.0.201708021857/ . It's built on the PR.
Open a Swager or OAS3 file - the editor is opened and functioning correctly.
Overview
Target Platform
I completely removed RepreZen Bundles plugin from the target platform.
Note: there are newer versions of Orbit libs available, we will migrate to them later.

I found it among other `bundleName`s by version.YamlErrorProcessor suffering from non-visible JacksonYAMLParseException and MarkedYAMLException
JacksonYAMLParseExceptionandMarkedYAMLExceptionare not Tycho-exposed in Orbit. So, had to use a hack to restore proper errors on the wrong indentation. The automated tests pass, I also manually tested it. But any new input is welcomeYAMLMappercannot be instantiated in TychoWhile
YAMLMapperis visible, using it throws an exception at runtime. The reason is that Jackson Dataformat library does not declare an OSGi dependency on Jackson Databind which is needed to initialize YAMLMapper (it extends ObjectMapper from Jackson Databind).Replacing
new YAMLMapper()withnew ObjectMapper(new YAMLFactory())solves it.