Skip to content

Conversation

@rbuccigrossi
Copy link
Contributor

@rbuccigrossi rbuccigrossi commented Mar 5, 2018

This detects and gracefully handles when there are no custom packages installed in a conda environment (so that our search for *.json is empty). This addresses #194 .

@codecov
Copy link

codecov bot commented Mar 5, 2018

Codecov Report

Merging #197 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   85.05%   85.08%   +0.02%     
==========================================
  Files         118      118              
  Lines        7922     7923       +1     
==========================================
+ Hits         6738     6741       +3     
+ Misses       1184     1182       -2
Impacted Files Coverage Δ
niceman/distributions/tests/test_conda.py 95.16% <100%> (ø) ⬆️
niceman/distributions/conda.py 92.09% <100%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb2d0ba...02eb6a7. Read the comment docs.


from niceman.distributions import Distribution, piputils
from niceman.dochelpers import exc_str
from niceman.support.exceptions import CommandError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With eabf08c, this import is unused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants