Skip to content

fix: print ready-for-review comment on all ready PRs, not just draft->ready PRs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MantisClone merged 1 commit into from
Mar 22, 2025
Merged

fix: print ready-for-review comment on all ready PRs, not just draft->ready PRs #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/pr-auto-comments.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,27 @@ jobs:
run: |
if [[ "${{ github.event_name }}" == "pull_request_target" ]]; then
if [[ "${{ github.event.action }}" == "opened" ]]; then
echo "type=opened" >> $GITHUB_OUTPUT
# Check if PR was opened and is not a draft
if [[ "${{ github.event.pull_request.draft }}" == "false" ]]; then
echo "type=opened" >> $GITHUB_OUTPUT
echo "type_ready=true" >> $GITHUB_OUTPUT
else
echo "type=opened" >> $GITHUB_OUTPUT
echo "type_ready=false" >> $GITHUB_OUTPUT
fi
elif [[ "${{ github.event.action }}" == "ready_for_review" ]]; then
echo "type=ready_for_review" >> $GITHUB_OUTPUT
echo "type_ready=true" >> $GITHUB_OUTPUT
elif [[ "${{ github.event.action }}" == "closed" && "${{ github.event.pull_request.merged }}" == "true" ]]; then
echo "type=merged" >> $GITHUB_OUTPUT
echo "type_ready=false" >> $GITHUB_OUTPUT
else
echo "type=other" >> $GITHUB_OUTPUT
echo "type_ready=false" >> $GITHUB_OUTPUT
fi
else
echo "type=other" >> $GITHUB_OUTPUT
echo "type_ready=false" >> $GITHUB_OUTPUT
fi

- name: Check if external contributor
Expand Down Expand Up @@ -150,7 +161,7 @@ jobs:
ready-for-review-comment:
name: Ready for Review Comment
needs: check-contributor
if: needs.check-contributor.outputs.event_type == 'ready_for_review' && needs.check-contributor.outputs.is_external == 'true' && inputs.ready_for_review_comment != ''
if: (needs.check-contributor.outputs.event_type == 'ready_for_review' || (needs.check-contributor.outputs.event_type == 'opened' && needs.check-contributor.outputs.type_ready == 'true')) && needs.check-contributor.outputs.is_external == 'true' && inputs.ready_for_review_comment != ''
runs-on: ubuntu-latest
steps:
- name: Leave ready for review comment
Expand Down