Conversation
benjlevesque
approved these changes
Nov 7, 2023
Contributor
benjlevesque
left a comment
benjlevesque
left a comment
There was a problem hiding this comment.
let's not use the matrix for chains that aren't on the hosted service?
We can make another step that deploys these.
alexandre-abrioux
approved these changes
Nov 7, 2023
Co-authored-by: Alexandre ABRIOUX <alexandre-abrioux@users.noreply.github.com>
MantisClone
reviewed
Nov 10, 2023
Member
MantisClone
left a comment
MantisClone
left a comment
There was a problem hiding this comment.
I agree with @benjlevesque that putting the non-hosted-service deployments into separate steps would be better than using a matrix. @leoslr I'm open to helping if you'd like, given my Issue #62 introduced the complex matrix.
alexandre-abrioux
approved these changes
Nov 15, 2023
Co-authored-by: Alexandre ABRIOUX <alexandre-abrioux@users.noreply.github.com>
Closed
This was referenced Dec 12, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment of the payment subgraph on Core for the following contracts:
Config updated to use specific URLs for the subgraph node (managed by Core).
Config and gh repo updated to use Core specific auth token