feat: graceful shutdown of request-node#463
Merged
benjlevesque merged 5 commits intomasterfrom Apr 7, 2021
Merged
Conversation
benjlevesque
commented
Mar 26, 2021
| @@ -14,7 +14,12 @@ | |||
| "noUnusedLocals": true, | |||
Contributor
Author
There was a problem hiding this comment.
fixes the Docker build (with the Dockerfile available in the monorepo)
benjlevesque
force-pushed
the
gracefully-stop-node
branch
from
e3ca1e4 to
b8ec6cc
Compare
vrolland
approved these changes
Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
Currently, shuting down a node running in Docker takes long time.
It is best practice to handle a graceful shutdown of an application, and reduces the deployment time significantly
unrelated change: removed some
anythat itched me 😁