feat: pn to smart-contract version mapping#649
Merged
benjlevesque merged 25 commits intomasterfrom Oct 29, 2021
Merged
Conversation
github-actions
bot
requested review from
KolevDarko,
bertux,
vrolland and
yomarion
benjlevesque
force-pushed
the
contract-version-mapping
branch
from
69c7483 to
7d7f55e
Compare
vrolland
approved these changes
Oct 26, 2021
benjlevesque
force-pushed
the
contract-version-mapping
branch
from
5a4337a to
7f68f70
Compare
yomarion
approved these changes
Oct 26, 2021
Contributor
yomarion
left a comment
yomarion
left a comment
There was a problem hiding this comment.
Awesome, congrats ! I'm glad we finally got rid of the payment-detection naming weirdness :)
bertux
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the payment method of the
payment-processorlibrary so that every method uses the mapping between PaymentNetwork and SmartContract as defined inpayment-detection.Since it was very hard to retrieve which class should define a mapping, I also did the following changes:
PaymentNetwork=>PaymentDetectorfor clarity, where appliable (payment detection library)