Bug Fix: Reply/Comment buttons not showing on feed items/comments/peer reviews #597
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
| <div className="flex items-center justify-between w-full"> | ||
| <div className="flex items-center space-x-3 md:space-x-4 flex-nowrap overflow-x-auto"> | ||
| <div className="flex items-center space-x-3 md:space-x-4 flex-nowrap overflow-visible"> | ||
| <div |
There was a problem hiding this comment.
This was updated because on feed/earn items, if you hovered over the comment button, a horizontal scroll bar would appear, even though everything fit on the screen.
types/feed.ts
Outdated
| * @param metrics - The content metrics containing comment count | ||
| * @param hasCommentAction - Whether the user has a way to comment (via callback or navigation) | ||
| */ | ||
| export function shouldHideCommentButton( |
There was a problem hiding this comment.
can we update this to work in the positive tense vs negative? That is, call it shouldShowCommentButton instead. We strive to name everything in positive vs negative form when reasonable.
Then we can have hideCommentButton={!shouldShowCommentButton(...)}
There was a problem hiding this comment.
Also let's move this to components/Feed/lib/feedUtils.tsx (I realize we don't have one yet but let's create one)
|
Overview
This PR fixes the Reply and Comment buttons on feed items, comments, and peer reviews by adding an additional check to see if it has an actionable, rather than only checking if it already has comments.
Screenshots
Feed Item:
Comments:
Peer Review:
