-
Notifications
You must be signed in to change notification settings - Fork 4
Add patch for broken SteamVR focus handling #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patch for broken SteamVR focus handling #62
Conversation
|
I also think making it disablable would be fine, just to keep it the same as all the other ones - though that would only concern the not updating the resolution part 🤔 You can use a ResoniteBugFixMonkey as the base, too |
|
this patches Unity stuff so it will break after splittening |
Yea, will have to see how we deal with that when the pre-release comes out - and it'll still be needed then, since there'll still be Unity for rendering |
3998018 to
5670500
Compare
|
Fixed the things that came up, I'll leave it up to you to decide whether you want to merge this so close to the split, I fully understand if you'd rather hold off for now. This might not even be a real issue anymore afterwards, depending on how the Unity renderer is implemented. If it doesn't lock the main thread while waiting for data from the engine I assume it would be very rare for someone to run into this :) |
It doesn't directly reference any types, so nothing else will break even if the process it's loaded in doesn't have Unity, so it's all good :D
Still something that could feasibly happen, so it doesn't hurt to have it fixed imo |
This fixes an issue wherein the resolution scale for SteamVR cameras could become permanently stuck on 0.5f due to broken logic in SteamVR.
I wasn't sure if this really fits into "Resonite Monkeys" but it causes headaches in Resonite since it does tend to hitch a lot, which causes the bug to reproduce, and there isn't a better spot from what I can tell apart from making a separate mod.
Yellow-Dog-Man/Resonite-Issues#2337