Improve Ruby and Python json object enumeration#61
Merged
ralreegorganon merged 5 commits intomasterfrom Jul 3, 2014
Merged
Conversation
* Cleanup case json in tests * Fix python key existence check test * Add ruby json object enumeration test
Contributor
There was a problem hiding this comment.
Will this ever be false? If we're inside of a Config instance, that means the underlying object was a hash, right?
Member
Author
There was a problem hiding this comment.
Good point--I think this is a bit of a legacy of the way I chopped up the commits from stuff that was attempting to handle arrays as well... and nuking everything but the inside of this statement (assume hash) still passes the tests...
I think I'll nuke it and let the actual array handling stuff add it back if it ends up being needed.
ralreegorganon
added a commit
that referenced
this pull request
Jul 3, 2014
Improve Ruby and Python json object enumeration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-picks 626ea83, ced8d5c and 285f4b4 from #53 , focusing on the json object enumeration problem. This doesn't solve the issues with enumerating arrays, but does deal with enumerating centroid wrapped dictionary/hash types.
CHANGELOG update to follow PR ID generation.