Add environment property when initializing using for_environment#63
Merged
Add environment property when initializing using for_environment#63
Conversation
added 3 commits
July 9, 2014 08:23
Adds `environment` property to Config when instantiated using `for_environment()`
Contributor
|
Looks good to me. Needs changelog entries though. |
Contributor
Author
|
Changelogged! |
Member
|
Looks good |
Contributor
Author
|
Do we want to do another prerelease? |
Member
|
If you want to cut a new prerelease after it's merged, that makes sense to me. |
jtroe
added a commit
that referenced
this pull request
Jul 10, 2014
Add environment property when initializing using for_environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves issue #62
Allows users to use which environment the configuration is for. In my case, this is especially useful for building paths which are different for each environment, such as
dot-net/{environment}/connection_info.txt