Conversation
* Automatic whitespace changes (remove BOM, trim trailing whitespace) * Explicitly set methods as private instead of leaving it to C#
* Gimme for python and ruby * This is needed in .net to dynamically reference configuration values based on class name. The referencing code is in a base class, and the named configuration key is that of the derived class
* Tests merging the given environment block into the 'all' block
jtroe
approved these changes
Oct 13, 2016
Contributor
jtroe
left a comment
jtroe
left a comment
There was a problem hiding this comment.
Looks good to me. Tests pass. Appears to be backwards compatible.
and create a version bump PR and I'll see if I can find all the stuff to ship the packages! 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take 2 on PR 69
In short this enables C# to generate key names and reference them dynamically.
Before, the key had to be hardcoded, e.g.
config.task.task1.param1. With this change you can do something like: