Allow custom Quoter to be injected into CompositeHandler::create()#14
Merged
henriquemoody merged 1 commit intoRespect:mainfrom May 10, 2026
Merged
Conversation
Previously, `create()` hardcoded `CodeQuoter` internally, giving callers no way to influence how values are quoted without rebuilding the entire handler chain manually. Now it accepts an optional `Quoter` parameter, defaulting to `CodeQuoter` to preserve backward compatibility. This makes the factory method more extensible: users can pass whichever `Quoter` implementation works best for their context — for example, a plain quoter that omits code formatting, or a custom one with different length limits — without having to bypass `create()` entirely. Assisted-by: Claude Code (claude-sonnet-4-6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
create()hardcodedCodeQuoterinternally, giving callers no way to influence how values are quoted without rebuilding the entire handler chain manually. Now it accepts an optionalQuoterparameter, defaulting toCodeQuoterto preserve backward compatibility.This makes the factory method more extensible: users can pass whichever
Quoterimplementation works best for their context — for example, a plain quoter that omits code formatting, or a custom one with different length limits — without having to bypasscreate()entirely.Assisted-by: Claude Code (claude-sonnet-4-6)