Remove SORT_REGULAR flag from unique rule #1534
Conversation
|
Thank you for your pull request, @dvdheiden! A few changes before we merge your code. Could you add some tests to cover the new changes and write the reason for the change in the body of the commit message? |
|
I've already added the testcase from the issue to the tests, see: https://github.com/Respect/Validation/pull/1534/files#diff-d86b663dae78d131902ff8c8552a2df8fdf484cb3f882aacd0616e3dbfb0493aR38 which covers this specific problem. I've added the commit message body as you requested. |
|
Thank you so much! However, it seems like you have 3 commits now instead of 1 with the description, I think you will need to rebase your branch |
When SORT_REGULAR is provided to array_unique, it does a loose comparison which makes it think ’14.1’ and ’14.10’ are the same.
|
Done |
|
I'm sorry for delaying this for so long, I have been quite busy. I created another pull request because the tests on this one were failing. I had to make lots of changes to make everything work as expected. |
|
Thank you for contributing! 🐼 P.S: I'm sorry for overwriting your pull request, but I thought it would be best to see what I could make of it, and as it turned out, the problem was quite complicated. |
|
No problem, especially because of your (understandable) explanation. Thank you for your work on this package! |
2 participants
Closes #1533