Prevent validators from generating validatorBuilder Ids
#1611
+91
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
=========================================
Coverage 97.93% 97.93%
- Complexity 958 960 +2
=========================================
Files 197 197
Lines 2228 2230 +2
=========================================
+ Hits 2182 2184 +2
Misses 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
henriquemoody
force-pushed
the
core/id
branch
from
1d03747 to
1a0d317
Compare
henriquemoody
force-pushed
the
core/id
branch
from
1a0d317 to
501829e
Compare
henriquemoody
changed the title
catchAll functionvalidatorBuilder Ids
alganet
requested changes
Jan 26, 2026
henriquemoody
force-pushed
the
core/id
branch
from
501829e to
a72b3eb
Compare
alganet
approved these changes
Jan 26, 2026
When calling `v::validatorName()`, a `ValidatorBuilder` is instantiated to manage the validation chain. However, users generally expect the ID to reflect the specific validator invoked rather than the internal builder class. This commit updates `Id::fromValidator()` to resolve the ID from the underlying validator when it is the sole member of the `ValidatorBuilder`, ensuring more intuitive identification.
henriquemoody
force-pushed
the
core/id
branch
from
a72b3eb to
a107b8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
v::validatorName(), aValidatorBuilderis instantiated to manage the validation chain. However, users generally expect the ID to reflect the specific validator invoked rather than the internal builder class.This commit updates
Id::fromValidator()to resolve the ID from the underlying validator when it is the sole member of theValidatorBuilder, ensuring more intuitive identification.