Fix wrong behaviour on Size rule #375
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation was made only on `validate()` method, but it was necessary to overwrite `assert()` and `check()` to replace the filename by the size. The `Size` rule now doesn't extends `Between` class, and instead it extends `AbstractRule` and performs the validation only on `validate()` method like many other rules.
Member
Author
|
Manual cherry-pick 4f8faab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation was made only on
validate()method, but it wasnecessary to overwrite
assert()andcheck()to replace the filenameby the size.
The
Sizerule now doesn't extendsBetweenclass, and instead itextends
AbstractRuleand performs the validation only onvalidate()method like many other rules.