Conversation
Contributor
|
Great job @anhntnguyen for providing the patch and test case for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fix for #1905 and also customer open zendesk ticket number #34319
Here is the CI result:
https://mobicents.ci.cloudbees.com/view/RestComm/job/RestComm-For-Specific-Branch/59/#showFailuresLink
Test Result (33 failures )
org.restcomm.connect.dao.mybatis.CallDetailRecordsDaoTest.testReadByEndTime
org.restcomm.connect.mgcp.LinkTest.testSuccessfulScenarioWithModify
org.restcomm.connect.mgcp.LinkTest.testSuccessfulScenario
org.restcomm.connect.testsuite.http.AccountsEndpointTest.testCreateAccountWithJapaneseChars
org.restcomm.connect.testsuite.http.CreateCallsTest.createCallNumberTest
org.restcomm.connect.testsuite.http.LiveCallModificationAnswerDelayTest.testTerminateDialForkCallWhileRinging_LCM_to_initial_call
org.restcomm.connect.testsuite.http.LiveCallModificationTest.holdCall
org.restcomm.connect.testsuite.http.LiveCallModificationTest.testTerminateDialForkCallWhileRinging_LCM_to_dial_branches
org.restcomm.connect.testsuite.http.LiveCallModificationTest.testTerminateDialForkCallWhileRinging_LCM_to_initial_call
org.restcomm.connect.testsuite.http.LiveCallModificationTest.testTerminateDialForkCallWhileRinging_LCM_to_move_initial_call_to_hangup_rcml
org.restcomm.connect.testsuite.http.UsageRecordsTest.getUsageRecordsDaily
org.restcomm.connect.testsuite.http.UsageRecordsTest.getUsageRecordsMonthly
org.restcomm.connect.testsuite.http.UsageRecordsTest.getUsageRecordsYearly
org.restcomm.connect.testsuite.http.UsageRecordsTest.getUsageRecordsAlltime
org.restcomm.connect.testsuite.provisioning.number.voxbone.VoxboneIncomingPhoneNumbersEndpointTest.testPurchaseAndDeletePhoneNumberSuccess
org.restcomm.connect.testsuite.provisioning.number.voxbone.VoxboneIncomingPhoneNumbersEndpointTest.testPurchasePhoneNumberNoPhoneNumberFound
org.restcomm.connect.testsuite.telephony.CallLifecycleTest.testDialCancelBeforeDialingClientAliceAfterTrying
org.restcomm.connect.testsuite.telephony.CallLifecycleTest.testDialCancelBeforeDialingClientAliceAfterRinging
org.restcomm.connect.testsuite.telephony.CallLifecycleTest.testDialClientAliceWithTimeLimit
org.restcomm.connect.testsuite.telephony.ClientsDialAnswerDelayTest.testClientDialOutPstnSimulateWebRTCClientNoAnswer
org.restcomm.connect.testsuite.telephony.ClientsDialTest.testDialClientAliceWithExtraParamsAtContactHeader
org.restcomm.connect.testsuite.telephony.ClientsDialTest.testClientsCallEachOther
org.restcomm.connect.testsuite.telephony.DialRecordingS3UploadAnswerDelayTest.testDialClientAlice_BobDisconnects
org.restcomm.connect.testsuite.telephony.DialRecordingS3UploadAnswerDelayTest.testDialClientAlice_AliceDisconnects
org.restcomm.connect.testsuite.telephony.ImsClientsDialAnswerDelayTest.testWebRTCClientIncomingBusy
org.restcomm.connect.testsuite.telephony.ImsClientsDialAnswerDelayTest.testWebRTCClientIncomingBHold
org.restcomm.connect.testsuite.telephony.ImsClientsDialAnswerDelayTest.testWebRTCClientOutgoingAHold
org.restcomm.connect.testsuite.telephony.ImsClientsDialTest.testWebRTCClientIncomingADisconnect
org.restcomm.connect.testsuite.telephony.ReferTest.org.restcomm.connect.testsuite.telephony.ReferTest
org.restcomm.connect.testsuite.telephony.TestDialVerbPartTwo.testDialConferenceNoDialActionNoSms
org.restcomm.connect.testsuite.telephony.TestDialVerbPartTwo.testDialClientAliceWithRecordAndStatusCallbackForAppForThreeCalls
org.restcomm.connect.testsuite.telephony.TestDialVerbPartTwo.testRecordWithActionAndStatusCallbackForAppWithBobSendsFinishKey
org.restcomm.connect.testsuite.telephony.TestMgcpOperations.testDialHelloPlay