RESTCOMM-1625: Handle Route Header for MultiProvider config

[abdulazizali77]

@gvagenas @deruelle George, VVS, please have a look

Motivation:

• Push routes defined in MultiProvider outbound-voice config.

Modification:

• Move the duplicated CallManager and Call addHeadersToMessage to B2BUAHelper
• Add explicit handling for Route headers
• Save outboundHeaders to incoming request SipSession and modify B2BUA invite
• Fetch outboundHeaders during challenge response and modify linked B2BU invite
• Fix proxyPassword

Result:

• WebRTC/B2BUA calls will be able to modify headers and add Route headers

[deruelle]

adding @leftyb as well.

[jaimecasero]

this is just relocating the addHeaders logic to the B2BUAHelper to be used from anywhere as an util,right?

[abdulazizali77]

Correct. We also added the specific Route handling to push the route

[jaimecasero]

i take this was duplicated from Call logic, exactly same code?

[abdulazizali77]

The only difference being the two were referring to private sipFactory, which we added as a param in the relocated one

[jaimecasero]

B2BUAHelper.isB2BUASession(response) == (B2BUAHelper.getLinkedSession(response) != null)

[abdulazizali77]

B2BUAHelper.isB2BUASession(response) basically checks for the existence of a session in the message.
Since the block previously did not need to access any session data, it did not retrieve the SipSession. Now we do need to one access session attribute EXTENSION_HEADERS so we do need the local SipSession

[jaimecasero]

i take this is actually the only change to fix the issue, is it not the same condition as before?

[abdulazizali77]

Previously we never modified the headers for this B2BUA/challenge request case.

[jaimecasero]

for me this PR is ok to be merged, we just need to confirm on testsuite results.

would it make sense to add a testcase for the new feature, to check extensionHeaders are added appropiately?

[abdulazizali77]

@jaimecasero The tests PR are here
https://bitbucket.org/telestax/telscale-restcomm/pull-requests/60/add-multiprovider-route-tests

[jaimecasero]

im ok merging this when test results are ready