Merged
Conversation
jaimecasero
reviewed
Apr 18, 2018
| // try to get destinationOrganizationSid from Refer-To | ||
| Address referAddress; | ||
| try { | ||
| referAddress = request.getAddressHeader("Refer-To"); |
Contributor
There was a problem hiding this comment.
i was hpoing to do this in REFER logic so is actually only attempted there, but i guess the perf penalty is minimal if any.
i was just wondering whether refer-to should take preference if present to actual toHeader. I hope if they are both present,they will be probably the same. In my mindf or refer case, refer-to header shoudl be first option, but we dont have anything (spec,req) to enforce that...
this will surely fix the customer usecase anyway.
i guess is ok to merge if ci results are good
added 5 commits
April 19, 2018 11:15
* master: Added extra log statements around the check of client Authorization header Updated External project version DigestAuthentication unit test Fixes for 8.4.0 release notes. This close RESTCOMM-2054 Patch for race condition when SBC is enabled, where the Cancel from one of the forking branches will cause the initial call state to be marked as Canceled and thus the Bye wont be send at the end of the call. This refer to RESTCOMM-1932 added release notes log,and link to main page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.