[WIP]jira-2165 RC should send BYE to XMS when stop recording.#2956
[WIP]jira-2165 RC should send BYE to XMS when stop recording.#2956maria-farooq merged 4 commits intomasterfrom
Conversation
| this.mediaGroup.getSignalDetector().stop(); | ||
| this.collecting = Boolean.FALSE; | ||
| } | ||
| call.tell(new RecordStoped(), self); |
There was a problem hiding this comment.
do we need to provide smae change for non JSR309 controller? Is this scenario causing same effect when we have RMS integrated?
There was a problem hiding this comment.
@jaimecasero
Line 791:
https://github.com/RestComm/Restcomm-Connect/pull/2956/files/2772b7dc7d20cc069d1ae12ebb06e39f55019371#diff-57215364d1e805510727c150e410959bL791
This line of code hold the thread for more than 2 seconds every time RestComm want to stop recording from XMS.
When finish Record verb RC does:
VoiceInterpreter send signal to stop recording to Jsr309CallController actor.
Jsr309CallController thread was block at line 791 for 2 second.
In the mean time Jsr309CallController is blocked, VoiceInterpreter send signal to close media session, but Jsr309CallController is blocked so the signal was ignored and then BYE cannot send to XMS.
In non JSR309, the code does not have any block point, so DELETE MGCP still send to RMS.
|
@xhoaluu can you merge with latest master to check test results on CI again please? i think some of the failing tests were fixed on master |
xhoaluu
changed the title
* master: (97 commits) fixed partialresult gather notification. Do not expect any RCML from notification. http client stuff relocated to interpreter.This reduces undesired dependencies in the project added more comments for partialResultCallback added test to check startInputKeys att Fixed DigestAuthenticationTest to properly use CallControlHelper.permitted() method added docker tag fixed style Update release-notes.adoc fixed typo on logging fixed bad query syntax fixed modifying record on inmutable SessionInfo object added debug log for smsservice actor fixed cache-path to be applied independent to RMS config style fixed updated for sprint3 activties fixing wrong text, phonenumber to client fixing wrong text, lowercase to uppercase fixing wrong text fixing Service Provider Fixing URLs in docs to match the restcomm cloud URLs ...
* master: added incoming release notes do not pass session timeout to Call actor handling session expiration properly. B2BUA sessions dropped accordingly add automatic update max-p2p-call-length from advance.conf using aka ask partten when sending completed status adjust align in restcomm.xml add P2P max Call Length Configuration
3 participants
What this PR does / why we need it:
RC does not send BYE to XMS if Record verb at the end, Caller drop the call at middle of record. That make XMS resource cannot be released.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
https://telestax.atlassian.net/browse/RESTCOMM-2165
Special notes for your reviewer:
All information is provided in Jira ticket.