Fix unexpected behavior with nested mappings#1496
Closed
AlexDenisov wants to merge 1 commit intoRestKit:developmentfrom
Closed
Fix unexpected behavior with nested mappings#1496AlexDenisov wants to merge 1 commit intoRestKit:developmentfrom
AlexDenisov wants to merge 1 commit intoRestKit:developmentfrom
Conversation
ghost
assigned
Member
|
I am going to need to digest this and think through appropriate test coverage. It's alarming to me that this change hasn't broken anything in the suite. Dropping on 0.20.4 |
Contributor
Author
|
Hi @blakewatters, have you any updates on this issue? |
Member
|
Sorry running with a bit of a backlog. I am going to sprint through the open PR's soon |
Use only 'high'-level mappings while searching through response descriptors
Contributor
Author
|
How is it going? 😄 |
Contributor
Author
|
nevemind |
Member
|
@AlexDenisov sorry that we never got back to you. It was never quite clear to me what problems this PR was intended to solve, especially since there were never any new tests added. |
Contributor
Author
|
@segiddins no problem :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This little patch solves problem described by myself here #177.
I'm not sure that I do it right, but specs aren't broken.
Also I haven't add tests on this case, because of lack of time. But I can do this soon, in a few days.