Small bug fix for constants in on-the-fly message classes #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit constant values like "1.0", i.e., floats that are integer, were not correctly treated in the md5sum calculation -- they were abbreviated to "1", causing incorrect md5sums. This commit fixes that by using the original string value for md5sum calculation.
chris-smith
approved these changes
Oct 14, 2016
chfritz
added a commit
to chfritz/rosjs
that referenced
this pull request
Oct 19, 2016
…otics-opensource#33) Prior to this commit constant values like "1.0", i.e., floats that are integer, were not correctly treated in the md5sum calculation -- they were abbreviated to "1", causing incorrect md5sums. This commit fixes that by using the original string value for md5sum calculation (up to the start of a comment (for strings) or the first whitespace character for any other field type). - also fixing some wrong logic for null values
chfritz
added a commit
to chfritz/rosjs
that referenced
this pull request
Oct 19, 2016
…otics-opensource#33) Prior to this commit constant values like "1.0", i.e., floats that are integer, were not correctly treated in the md5sum calculation -- they were abbreviated to "1", causing incorrect md5sums. This commit fixes that by using the original string value for md5sum calculation (up to the start of a comment (for strings) or the first whitespace character for any other field type). - also fixing some wrong logic for null values
chfritz
added a commit
to chfritz/rosjs
that referenced
this pull request
Oct 24, 2016
…otics-opensource#33) Prior to this commit constant values like "1.0", i.e., floats that are integer, were not correctly treated in the md5sum calculation -- they were abbreviated to "1", causing incorrect md5sums. This commit fixes that by using the original string value for md5sum calculation (up to the start of a comment (for strings) or the first whitespace character for any other field type). - also fixing some wrong logic for null values
chfritz
added a commit
to chfritz/rosjs
that referenced
this pull request
Oct 24, 2016
…otics-opensource#33) Prior to this commit constant values like "1.0", i.e., floats that are integer, were not correctly treated in the md5sum calculation -- they were abbreviated to "1", causing incorrect md5sums. This commit fixes that by using the original string value for md5sum calculation (up to the start of a comment (for strings) or the first whitespace character for any other field type). - also fixing some wrong logic for null values
chfritz
added a commit
to chfritz/rosjs
that referenced
this pull request
Oct 27, 2016
…otics-opensource#33) Prior to this commit constant values like "1.0", i.e., floats that are integer, were not correctly treated in the md5sum calculation -- they were abbreviated to "1", causing incorrect md5sums. This commit fixes that by using the original string value for md5sum calculation (up to the start of a comment (for strings) or the first whitespace character for any other field type). - also fixing some wrong logic for null values
chris-smith
pushed a commit
that referenced
this pull request
Oct 27, 2016
Prior to this commit constant values like "1.0", i.e., floats that are integer, were not correctly treated in the md5sum calculation -- they were abbreviated to "1", causing incorrect md5sums. This commit fixes that by using the original string value for md5sum calculation (up to the start of a comment (for strings) or the first whitespace character for any other field type). - also fixing some wrong logic for null values
chris-smith
pushed a commit
to chris-smith/rosjs
that referenced
this pull request
Oct 27, 2016
…otics-opensource#33) (RethinkRobotics-opensource#34) Prior to this commit constant values like "1.0", i.e., floats that are integer, were not correctly treated in the md5sum calculation -- they were abbreviated to "1", causing incorrect md5sums. This commit fixes that by using the original string value for md5sum calculation (up to the start of a comment (for strings) or the first whitespace character for any other field type). - also fixing some wrong logic for null values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit constant values like "1.0", i.e., floats that are
integer, were not correctly treated in the md5sum calculation -- they
were abbreviated to "1", causing incorrect md5sums. This commit fixes
that by using the original string value for md5sum calculation.