Bring BRP system into FoundryVTT v14 compliance#1
Merged
Conversation
Agent-Logs-Url: https://github.com/RevCivic/brp/sessions/1123c6c1-0cce-49c9-88c8-3d47a065c85f Co-authored-by: RevCivic <22403423+RevCivic@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
RevCivic
April 7, 2026 21:10
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the BRP system to be compatible with FoundryVTT Version 14.
Changes
The primary breaking change in FoundryVTT v14 is the removal of jQuery from the framework. All jQuery DOM API calls have been replaced with native browser DOM APIs throughout the codebase.
Files changed
system.jsonversionto14.1.56compatibility.verifiedto14compatibility.maximumto14jQuery → native DOM replacements:
module/actor/sheets/base-actor-sheet.mjs— 3 jQuery instances ($(el).closest(),.data())module/apps/check.mjs— 1 instance ($(el).closest('.message'))module/actor/actor.mjs— 1 instance ($(el).find(...).css(...))module/item/item.mjs— 1 instance (same pattern)module/item/sheets/profession.mjs— 4 instancesmodule/item/sheets/culture.mjs— 3 instancesmodule/item/sheets/skill.mjs— 2 instancesmodule/item/sheets/personality.mjs— 3 instancesmodule/item/sheets/super.mjs— 2 instancesmodule/brpid/brpid-editor.mjs— 5 instances ($(this).data(),$(target).siblings(),$(el).find(...).css(...))module/hooks/render-dialog.mjs— full rewrite using native DOMmodule/hooks/render-journal-text-page-sheet.mjs— full rewrite using native DOMmodule/hooks/render-journal-entry-page-text-sheet.mjs— toggle handler rewrittenmodule/hooks/render-journal-sheet.mjs—html.hasClass/addClass/$(html)replacedAdditional fixes:
base-actor-sheet.mjs:CONST.CHAT_MESSAGE_OTHER→CONST.CHAT_MESSAGE_STYLES.OTHERbrpid-editor.mjs: Removed deprecated{ async: true }option fromTextEditor.enrichHTMLcalls (always async in v14)