feat(PLU-183): update interface to match other plugins #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettwold
reviewed
Sep 23, 2025
src/main/java/ai/reveng/toolkit/ghidra/binarysimilarity/ui/help/HelpDialog.java
Show resolved
Hide resolved
brettwold
approved these changes
Sep 23, 2025
fmagin
requested changes
Sep 23, 2025
Collaborator
fmagin
left a comment
fmagin
left a comment
There was a problem hiding this comment.
Some design decisions like the mouse click handler seem unidiomatic instead of a Context action as linked. Unless this specific UX of just needing to click is a product decision I would recommend changing it.
The manual refreshes of the UI action seems entirely unnecessary, and should be handled with a dedicated call to PluginTool.contextChanged. If that doesn't address it then I will look into the idiomatic approach.
...n/java/ai/reveng/toolkit/ghidra/binarysimilarity/ui/recentanalyses/RecentAnalysisDialog.java
Show resolved
Hide resolved
...n/java/ai/reveng/toolkit/ghidra/binarysimilarity/ui/recentanalyses/RecentAnalysisDialog.java
Outdated
Show resolved
Hide resolved
src/main/java/ai/reveng/toolkit/ghidra/binarysimilarity/BinarySimilarityPlugin.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.