LiteNetLib v7.7.2 Hung in Thread.Sleep(SleepTime) in LiteNetLib/NetThread.cs using Unity 2018.3.0b10/0b8

[marcejohnson]

Using awesome LiteNetLib v7.7.2 with Unity 2018.3.0b10/0b8, with client code adopted from helpful udemy course ("Unity LiteNetLib Multiplayer Basics and .NET Core Server"), compiled to OSX 10.14.1.

Code runs great for about 10 minutes and then locks up. When I attach VS debugger and pause, stuck at Line 99 (Thread.Sleep) of LiteNetLib/NetTread.cs

private void ThreadLogic()
        {
            while (_running)
            {
                _callback();
                Thread.Sleep(SleepTime);
            }
        }

Library version: release version (0.7.7.2)]

Framework: Unity 2018.3.0b10 and 2018.3.0b8

OS: OSX 10.14.1

Call Stack

And here are the details... let me know what else would help.

System.Threading.Thread.SleepInternal() in 
System.Threading.Thread.Sleep(int millisecondsTimeout) in 
LiteNetLib.NetThread.ThreadLogic() in /Users/marc/tron-terrain/Assets/Scripts/LiteNetLib/NetThread.cs:99
System.Threading.ThreadHelper.ThreadStart_Context(System.Threading.ThreadHelper state) in 
System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Threading.ThreadHelper state, bool preserveSyncCtx) in 
System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Threading.ThreadHelper state, bool preserveSyncCtx) in 
System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Threading.ThreadHelper state) in 
System.Threading.ThreadHelper.ThreadStart() in 

Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/mscorlib.dll
Thread started:  #1
Thread started:  #1
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.AIModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.ARModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.AccessibilityModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.AnimationModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.AssetBundleModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.AudioModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.BaselibModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.ClothModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.ClusterInputModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.ClusterRendererModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.CoreModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.CrashReportingModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.DirectorModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.FileSystemHttpModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.GameCenterModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.GridModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.HotReloadModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.IMGUIModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.ImageConversionModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.InputModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.JSONSerializeModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.LocalizationModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.ParticleSystemModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.PerformanceReportingModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.PhysicsModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.Physics2DModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.ProfilerModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.ScreenCaptureModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.SharedInternalsModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.SpatialTrackingModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.SpriteMaskModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.SpriteShapeModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.StreamingModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.StyleSheetsModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.SubstanceModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.TLSModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.TerrainModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.TerrainPhysicsModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.TextCoreModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.TextRenderingModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.TilemapModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.TimelineModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.UIModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.UIElementsModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.UNETModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.UmbraModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.UnityAnalyticsModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.UnityConnectModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.UnityTestProtocolModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.UnityWebRequestModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.UnityWebRequestAssetBundleModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.UnityWebRequestAudioModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.UnityWebRequestTextureModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.UnityWebRequestWWWModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.VFXModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.VRModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.VehiclesModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.VideoModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.WindModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.XRModule.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/System.Core.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/System.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.UI.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.Timeline.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.Networking.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/UnityEngine.SpatialTracking.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/Assembly-CSharp-firstpass.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/Assembly-CSharp.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/Assembly-UnityScript-firstpass.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/Assembly-UnityScript.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/Unity.TextMeshPro.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/Unity.Analytics.DataPrivacy.dll
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/netstandard.dll
Thread started:  #2
Thread started: SocketThreadv4(58873) #3
Thread started: SocketThreadv6(58873) #4
Thread started: LogicThread #5
Loaded assembly: /Users/marc/crashjump_mac_20181118.app/Contents/Resources/Data/Managed/Boo.Lang.dll
Thread started: SocketThreadv4(54868) #7
Thread started: SocketThreadv6(54868) #8
Thread started: LogicThread #9

Known issue? Thank you for any tips! Happy to debug further if you want more details.

_Marc

[marcejohnson]

OK, good news: after reading through older issues, on the client I added peer.Flush() at beginning of OnNetworkReceive(...) before receiving data. For good measure added clientNetManager.Flush() at the beginning of FixedUpdate() before sending data. Seems to have stopped the hang/locking. Yay!

But Why?

I understand adding Flush(es) to decrease latency of sends... but they should be optional, right? The library eventually gets around to sending? Or are they necessary to prevent locks/hangs in 7.7.2 like I was seeing above?

Any specific guidance on when and where to use flush (clientNetManager.Flush() vs peer.Flush)? Before or after which read/write operations? Tradeoffs?

Thanks much!

[RevenantX]

@marcejohnson seems that this is some OSX/Unity specific bug. Try 0.8 version from master.

[marcejohnson]

@RevenantX OK! I pulled it in and seeing it will take a bit of a refactor going from v0.7.7.2 to 0.8 but will take the plunge! Also, I am a bit concerned about this issue: #242

I'll update back here. When I'm successful, maybe I can help port and test the existing Unity examples (if necessary).

[marcejohnson]

Update: latest Unity (beta 2018.3.0b10) + LiteNetLib 0.8 + OSX working like a champ. Compiled to Linux, Android and Windows too ... all working. The issue described above is not occurring with this combo. I'll close this ticket. Thanks!