Update NetDataReader, NetDataWriter & FastBitConverter + add docs#594
Merged
RevenantX merged 12 commits intoRevenantX:masterfrom Mar 22, 2026
Merged
Update NetDataReader, NetDataWriter & FastBitConverter + add docs#594RevenantX merged 12 commits intoRevenantX:masterfrom
RevenantX merged 12 commits intoRevenantX:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
NetDataReader&NetDataWriterto use faster methods of reading/writing dataFastBitConverterto useWriteUnaligned<T>()These methods have been used in Project Fika for a very long time without issue, and as such I have decided to PR them per our discussion on Discord.
No signatures should be changed, meaning users do not have to update anything on their end.
I have included conditional compilation directives where >.NET 8 uses the

Unsafeclass, and netstandard2.1 (mainly for Unity) usesfixed, which is slower, but does not require external libraries. The difference is so small that it does not warrant the requirement of importing this library:I also changed to

Unsafe.WriteUnaligned<T>()inFastBitConverterfor >.NET 8 as it is faster when writing unaligned (see benchmark below)I have ran all tests and they are all successful. I also updated the tests to include some of the new methods, e.g. for
Unmanaged<T>andEnum. I am unsure how to test this for netstandard2.1 as there are no included tests for it.Please let me know if you'd like any changes or if there are any questions.