fix(LiteNetPeer): get packets count in reliable unordered channel#607
Merged
RevenantX merged 1 commit intoRevenantX:masterfrom Apr 16, 2026
Conversation
Owner
|
better remove default argument to avoid confusing |
stiefeljackal
force-pushed
the
fix/get-packets-count-in-reliable-unordered
branch
from
44a8e86 to
329b16c
Compare
Contributor
Author
Sure. The default argument has been removed. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While going through LiteNetLib, I noticed that
GetPacketsCountInReliableQueueinLiteNetPeeraccepts the argumentordered. Based on the comments, this argument should determine which channel,ReliableOrderedorReliableUnordered, the number of packets in queue should come from. However, it appears that the count is always coming from theReliableOrderedchannel despite the value passed in forordered. This PR aims to fix this behavior by returning the packet count for theReliableUnorderedchannel iforderedisfalse.I also made the argument default to
trueas well.