-
Notifications
You must be signed in to change notification settings - Fork 226
How to get your pull request accepted
Simon Hughes edited this page Nov 17, 2016
·
10 revisions
Have a read of [https://github.com/blog/1943-how-to-write-the-perfect-pull-request](How to write the perfect pull request)
My requirements are simple:
- Always keep the changes to a minimum, so I can see exactly what's changed in regard to the pull request. I.e. No whitespace tidy up, etc.
- No tabs, only spaces (4).
- Don't move functions about, please leave them where they are.
- No new files. This will always get rejected. Add any new code/classes into the two existing .ttinclude files.
- Don't be tempted to do a few different enhancements in one pull request. Have one pull request for one bug fix / enhancement.
Many thanks for taking the time to read this, and for wanting to contribute.
- Home
- Compared with the Microsoft scaffolder
- Connection strings
- JetBrains Rider
- Upgrading from v3 to v4
- Saving .tt does nothing
- Settings A-Z - every setting, with a page each
- Common Settings Types Explained
- Settings Callbacks
- Settings runtime values and helpers
- Filtering
- Full Control Over the Generated Code
- Enum Generation from Table Data
- Owned Entities
- JSON column support
- Global Query Filters
- Extended Property Names Feature
- Partial Properties
- File-Scoped Namespaces
- Data Annotations
- Spatial Types
- HierarchyId
- RowVersion and TimeStamp columns
- Lazy Loading
- Stored proc result sets