Skip to content

How to get your pull request accepted

Simon Hughes edited this page Nov 17, 2016 · 10 revisions

Have a read of [https://github.com/blog/1943-how-to-write-the-perfect-pull-request](How to write the perfect pull request)

My requirements are simple:

  1. Always keep the changes to a minimum, so I can see exactly what's changed in regard to the pull request. I.e. No whitespace tidy up, etc.
  2. No tabs, only spaces (4).
  3. Don't move functions about, please leave them where they are.
  4. No new files. This will always get rejected. Add any new code/classes into the two existing .ttinclude files.
  5. Don't be tempted to do a few different enhancements in one pull request. Have one pull request for one bug fix / enhancement.

Many thanks for taking the time to read this, and for wanting to contribute.

Clone this wiki locally