chore: align dev tooling with stage monorepo#13
Merged
Conversation
- Upgrade Biome 1.9 -> 2.4 with stricter rules (noExplicitAny: error, noFocusedTests, noConsole allowing error/warn, useExportType) and tab indentation. Reformat all source files. - Add husky 9 + lint-staged pre-commit hook running biome check --write on staged files. - Add .github/workflows/ci.yml (drizzle drift, lint, typecheck, test, build) and PULL_REQUEST_TEMPLATE.md. - Switch package manager from npm to pnpm@10.24.0 with packageManager field and onlyBuiltDependencies for native deps. - Slim .gitignore from ~150 lines to 26 by removing patterns for frameworks/tools this repo does not use. - Update AGENTS.md, TESTING.md, and agent docs to reflect new style and pnpm commands.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request transitions the project to pnpm, introduces pre-commit hooks via husky and lint-staged, and updates the Biome configuration to enforce stricter linting and tab-based indentation for JS/TS files. The changes involve a widespread reformatting of the codebase and updates to project documentation and scripts. Review feedback recommends using the ignore field in biome.json for directory exclusions to ensure more reliable behavior and suggests aligning the @biomejs/biome dependency version in package.json with the schema version used in the configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns this repo's dev tooling with the
~/Developer/stagemonorepo for cross-repo consistency: same Biome config, same pre-commit hooks, same CI shape, same package manager.Changes
noExplicitAny: error,noFocusedTests,noConsoleallowingerror/warn,useExportType) and tab indentation. All source files reformatted.biome check --writeon staged files..github/workflows/ci.ymlwith drizzle drift check → lint → typecheck → test → build, plus PR template.packageManagerfield andonlyBuiltDependenciesforbetter-sqlite3andesbuild..gitignorefrom ~150 lines to 26 — kept only what we actually generate.Testing
pnpm install✓pnpm lint✓pnpm typecheck✓pnpm test✓ (53 passed)pnpm buildandpnpm build:web✓pnpm db:generate✓ (no drift)