chore: copy skills/ into packages/cli at prepack time#34
Merged
Conversation
Extend the existing prepack script to also copy the root skills/ directory into packages/cli/skills/ so it ships in the published tarball. Add packages/cli/skills to .gitignore since it's generated.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the CLI package's build configuration to include the 'skills' directory during the prepack phase and adds the local directory to .gitignore. A review comment suggests enhancing the 'prepack' script to remove the destination directory before copying, ensuring that stale files are not included in the final package.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6d8ffa1. Configure here.
Address PR review feedback: fs.cpSync merges into the destination without removing deleted files. Add fs.rmSync before copying to ensure a clean, faithful copy every time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the prepack script to copy the root
skills/directory intopackages/cli/skills/so it ships in the published npm tarball alongside the existing README copy.Changes
prepackscript inpackages/cli/package.jsonto also runfs.cpSync('../../skills', './skills', {recursive: true})packages/cli/skillsto.gitignoresince it's generated at publish timeTesting
skills/is copied correctlypnpm typecheck,pnpm lint, andpnpm testall pass