Skip to content

Upgrade to lru-cache 11.#32

Merged
pkaminski merged 1 commit intomasterfrom
lru-cache-11
Feb 12, 2026
Merged

Upgrade to lru-cache 11.#32
pkaminski merged 1 commit intomasterfrom
lru-cache-11

Conversation

@pkaminski
Copy link
Copy Markdown
Member

@pkaminski pkaminski commented Feb 11, 2026

This change is Reviewable

@pkaminski pkaminski requested a review from snoack February 11, 2026 23:43
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Feb 11, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedlru-cache@​11.2.61001009991100

View full report

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades lru-cache to version 11. The code changes correctly reflect the API updates from the new version across all relevant files, including source code, documentation, and configuration. I've found one issue regarding Node.js engine compatibility in the tools package that should be addressed, aligning with the repository's Node.js version policy.

Comment thread tools/package.json
"firebase-admin": "^11.4.1",
"lodash": "^4.17.20",
"lru-cache": "^6.0.0",
"lru-cache": "^11.2.6",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading lru-cache to version 11 introduces a new Node.js version requirement (20 || >=22). However, the engines.node field for this package is still set to >=12.x (on line 11), which is now incompatible. Please update the engines field to align with the new dependency requirements and the repository's policy to target the oldest active Long-Term Support (LTS) version, for example to >=20.x.

References
  1. The required Node.js version in package.json should target the oldest active Long-Term Support (LTS) version.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd6c1b2cea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/package.json
"firebase-admin": "^11.4.1",
"lodash": "^4.17.20",
"lru-cache": "^6.0.0",
"lru-cache": "^11.2.6",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Align tools runtime floor with lru-cache v11 requirement

Upgrading firecrypt-tools to lru-cache@^11.2.6 raises the effective Node.js minimum to 20, but this package still declares "engines": {"node": ">=12.x"}; the updated lockfile also records lru-cache as "node": "20 || >=22" (tools/package-lock.json), so installs/runs on Node 12/14/16/18 (currently advertised as supported) will now fail or become unsupported. Please either keep a Node-12-compatible cache dependency or update the tools package engine constraint to match the new requirement.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkaminski resolved 2 discussions.
Reviewable status: 0 of 15 files reviewed, all discussions resolved (waiting on @snoack).

Copy link
Copy Markdown

@snoack snoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@snoack reviewed 15 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pkaminski).

@pkaminski pkaminski merged commit 493cff0 into master Feb 12, 2026
4 checks passed
@pkaminski pkaminski deleted the lru-cache-11 branch February 12, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants