Add solution for Challenge 21 by Johrespi #655
Conversation
WalkthroughA new Go source file is added to the Challenge 21 submissions directory containing three binary search implementations (iterative, recursive, and insertion position finder) along with a main harness demonstrating their usage on a sorted integer array. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (3)
challenge-21/submissions/Johrespi/solution-template.go (3)
30-41: Consider fixing indentation inconsistencies.The indentation appears inconsistent with a mix of spaces and tabs. Consider running
gofmtorgoimportsto standardize formatting across the file.
52-57: Consider moving mid calculation after base case check.The
midvariable is calculated before checking the base case (left > right). While this doesn't cause incorrect behavior, it performs an unnecessary calculation when the recursion terminates.Apply this diff to improve efficiency:
- - mid := left + (right - left)/2 - if left > right{ return -1 - } + + mid := left + (right - left)/2
28-45: Consider adding nil/empty array validation.The functions don't validate for nil arrays, which will cause a panic when accessing array elements. While empty arrays are handled correctly by the loop conditions, adding explicit validation would make the code more robust.
Example for BinarySearch:
func BinarySearch(arr []int, target int) int { + if arr == nil || len(arr) == 0 { + return -1 + } low := 0 high := len(arr) - 1Similar validation can be added to the other functions. However, if the challenge specification guarantees valid input, this may not be necessary.
Also applies to: 49-66, 70-86
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
challenge-21/submissions/Johrespi/solution-template.go(1 hunks)
🔇 Additional comments (1)
challenge-21/submissions/Johrespi/solution-template.go (1)
7-24: LGTM! Clean demonstration harness.The main function provides clear examples of all three binary search implementations with appropriate test cases.
| // BinarySearch performs a standard binary search to find the target in the sorted array. | ||
| // Returns the index of the target if found, or -1 if not found. | ||
| func BinarySearch(arr []int, target int) int { | ||
| // TODO: Implement this function |
There was a problem hiding this comment.
Remove TODO comment.
The TODO comment should be removed as the function is now implemented.
Apply this diff:
- // TODO: Implement this function📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // TODO: Implement this function |
🤖 Prompt for AI Agents
In challenge-21/submissions/Johrespi/solution-template.go around line 29, remove
the remaining "// TODO: Implement this function" comment now that the function
is implemented; delete that line and ensure surrounding code formatting/newlines
remain correct so the file compiles.
| // BinarySearchRecursive performs binary search using recursion. | ||
| // Returns the index of the target if found, or -1 if not found. | ||
| func BinarySearchRecursive(arr []int, target int, left int, right int) int { | ||
| // TODO: Implement this function |
There was a problem hiding this comment.
Remove TODO comment.
The TODO comment should be removed as the function is now implemented.
Apply this diff:
- // TODO: Implement this function📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // TODO: Implement this function |
🤖 Prompt for AI Agents
In challenge-21/submissions/Johrespi/solution-template.go around line 50, remove
the "// TODO: Implement this function" comment because the function is
implemented; simply delete that single-line TODO comment so the file contains
only the implemented function and no leftover placeholder comment.
| // FindInsertPosition returns the index where the target should be inserted | ||
| // to maintain the sorted order of the array. | ||
| func FindInsertPosition(arr []int, target int) int { | ||
| // TODO: Implement this function |
There was a problem hiding this comment.
Remove TODO comment.
The TODO comment should be removed as the function is now implemented.
Apply this diff:
- // TODO: Implement this function📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // TODO: Implement this function |
🤖 Prompt for AI Agents
In challenge-21/submissions/Johrespi/solution-template.go around line 71, remove
the leftover TODO comment ("// TODO: Implement this function") since the
function is already implemented; delete that comment line and ensure surrounding
formatting remains correct (no extra blank lines introduced).
2 participants
Challenge 21 Solution
Submitted by: @Johrespi
Challenge: Challenge 21
Description
This PR contains my solution for Challenge 21.
Changes
challenge-21/submissions/Johrespi/solution-template.goTesting
Thank you for reviewing my submission! 🚀