🔧(build): Use commit SHA for image tag and add push-cache control#2
Merged
Conversation
Remove the image-tag input and always derive the tag from GITHUB_SHA, using the first 6 characters. This ensures consistent, unique tagging based on the exact commit being built, rather than relying on git refs which may not always be present or consistent across workflows. Co-Authored-By: Claude <noreply@anthropic.com>
Add a push-cache input (default false) so cache is only written to the registry when explicitly enabled. Document in README that push-cache should only be enabled for images intended to be pushed to ECR. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
push-cacheinput to control whether layer cache is written back to the registryChanges
image-taginput; resolve tag fromGITHUB_SHAdirectlypush-cacheinput (defaultfalse) — cache is only pushed when explicitly enabledpush-cacheguidance in READMETesting
Checklist
Co-Authored-By: Claude noreply@anthropic.com