feat(sources): expose upstream url and render SourceFavicon#167
Merged
RhysSullivan merged 4 commits intoRhysSullivan:mainfrom Apr 11, 2026
Merged
feat(sources): expose upstream url and render SourceFavicon#167RhysSullivan merged 4 commits intoRhysSullivan:mainfrom
RhysSullivan merged 4 commits intoRhysSullivan:mainfrom
Conversation
Adds an optional `url` field on the `Source` SDK schema, the HTTP API response shape, and the handler projection. Each built-in plugin populates it with the relevant upstream endpoint: - `mcp`: remote transport's endpoint (undefined for stdio) - `graphql`: the configured endpoint - `openapi`: the spec baseUrl - `google-discovery`: the rootUrl Introduces `<SourceFavicon>`, a tiny component that extracts the base origin from the URL and resolves a favicon, with a skeleton placeholder while loading and a graceful fallback when the host doesn't serve one. Adopts it in both the cloud and local app shells — each sidebar entry now shows the upstream's favicon next to the source name, giving the list a much more recognizable "title-card" feel. Also renames the section header from "Configured" to "Sources".
Contributor
Author
|
@RhysSullivan ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
urlfield to theSourceschema and wires each built-in source plugin to populate it. Introduces a new<SourceFavicon>component that derives a favicon from the source URL's base origin, and uses it in both app shells to give the sidebar a recognizable "title-card" feel.Changes
Schema plumbing —
url?: stringonSourcepackages/core/sdk/src/sources.tspackages/core/api/src/sources/api.tspackages/core/api/src/handlers/sources.tsPlugin population
packages/plugins/mcp/src/sdk/plugin.ts— remote transport endpointpackages/plugins/graphql/src/sdk/plugin.ts— configured endpointpackages/plugins/openapi/src/sdk/plugin.ts— specbaseUrlpackages/plugins/google-discovery/src/sdk/plugin.ts—rootUrlUI
packages/react/src/components/source-favicon.tsx(new)apps/cloud/src/web/shell.tsx— sidebar favicon + "Sources" labelapps/local/src/web/shell.tsx— sidebar favicon + "Sources" labelNotes
SourceFaviconshows a skeleton while loading and falls back gracefully if the host doesn't serve a favicon, so sources without a URL (e.g. stdio MCP transports) still render cleanly.