refactor(mcp): adopt shared primitives in Add/Edit source forms#189
Open
mrzmyr wants to merge 3 commits intoRhysSullivan:mainfrom
Open
refactor(mcp): adopt shared primitives in Add/Edit source forms#189mrzmyr wants to merge 3 commits intoRhysSullivan:mainfrom
mrzmyr wants to merge 3 commits intoRhysSullivan:mainfrom
Conversation
Introduces four shared UI primitives that the upcoming source-form refactor relies on, keeping the refactor PR focused on wiring rather than new atoms: - <FilterTabs> — compact tab selector used by the shared auth section. - <FloatActions> — sticky bottom action bar for save/cancel on long forms (Claude / ElevenLabs-style editing UX). - <IOSSpinner> — iOS-style blade spinner for subtle inline loading states, paired with a new keyframe in globals.css. - <Textarea> — adds an optional maxRows prop so source-form preview/error panels can cap their height without bespoke wrappers. No consumers updated in this PR; follow-up PRs adopt them.
Introduces a shared auth block that every source plugin's Add/Edit form can reuse instead of rolling its own None / Bearer / Header / Basic UI. The section handles field-level validation via <FieldLabel> / <FieldError> and exposes a <FilterTabs>-based picker for the auth method. Also refreshes secret-header-auth.tsx to render errors inline on the field through <FieldGroup> / <FieldLabel> / <FieldError>, matching the new primitive's error style. No plugin consumers updated in this PR; follow-up PRs adopt it.
Replaces the hand-rolled auth/URL/headers UI with <AuthenticationSection>, wraps the save/cancel row in <FloatActions>, and uses <IOSSpinner> + <Textarea maxRows> for probe status and previews. The biggest single form in the source-form suite — isolated here so reviewers can focus on it without context-switching between plugins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 of 5 — source-forms refactor split from #169. Stacks on #188.
Replaces the hand-rolled auth/URL/headers UI in the MCP Add/Edit forms with
<AuthenticationSection>, wraps the save/cancel row in<FloatActions>, and uses<IOSSpinner>+<Textarea maxRows>for probe status and previews.The biggest single form in the source-form suite (~820 LOC touched) — isolated here so reviewers can focus on it without context-switching between plugins.
Stack
feat(react): add UI primitives for source formsfeat(react): add <AuthenticationSection> primitiverefactor(mcp): adopt shared primitives in Add/Edit source formsrefactor(sources): standardize openapi, graphql, google-discovery, onepassword formsrefactor(react): restructure sources list and sources-add container