Skip to content

feat(react): use favicon on connected source list items#226

Merged
RhysSullivan merged 3 commits intoRhysSullivan:mainfrom
mrzmyr:feat/source-favicon-connected-list
Apr 13, 2026
Merged

feat(react): use favicon on connected source list items#226
RhysSullivan merged 3 commits intoRhysSullivan:mainfrom
mrzmyr:feat/source-favicon-connected-list

Conversation

@mrzmyr
Copy link
Copy Markdown
Contributor

@mrzmyr mrzmyr commented Apr 13, 2026

Summary

  • Replace the generic SVG icon in the connected sources list with SourceFavicon, rendering the actual site favicon from the source URL
  • Match favicon size (20px) to the popular sources list for visual consistency
  • Falls back to a BoxIcon when no URL is available or the image fails to load

Before

CleanShot 2026-04-13 at 12 26 29

After

CleanShot 2026-04-13 at 12 25 54

Test plan

  • Verify connected sources with a URL show their site favicon
  • Verify sources without a URL show the fallback BoxIcon
  • Verify favicon size matches the popular sources list icons

mrzmyr added 2 commits April 13, 2026 12:08
Replace the generic SVG icon in the connected sources list with
SourceFavicon, which renders the site's actual favicon from the
source URL.
@mrzmyr mrzmyr marked this pull request as draft April 13, 2026 10:24
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 13, 2026

Open in StackBlitz

@executor/sdk

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/sdk@226

@executor/plugin-file-secrets

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-file-secrets@226

@executor/plugin-google-discovery

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-google-discovery@226

@executor/plugin-graphql

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-graphql@226

@executor/plugin-keychain

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-keychain@226

@executor/plugin-mcp

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-mcp@226

@executor/plugin-onepassword

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-onepassword@226

@executor/plugin-openapi

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-openapi@226

@executor/plugin-workos-vault

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-workos-vault@226

commit: 2ec1748

@mrzmyr mrzmyr marked this pull request as ready for review April 13, 2026 10:26
@RhysSullivan RhysSullivan merged commit b685f36 into RhysSullivan:main Apr 13, 2026
5 checks passed
@RhysSullivan
Copy link
Copy Markdown
Owner

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants