[codex] Improve dynamic worker error formatting#241
Closed
heyglassy wants to merge 3 commits intoRhysSullivan:mainfrom
Closed
[codex] Improve dynamic worker error formatting#241heyglassy wants to merge 3 commits intoRhysSullivan:mainfrom
heyglassy wants to merge 3 commits intoRhysSullivan:mainfrom
Conversation
Keep namespace inputs permissive during typing so underscores do not disappear from the Executor Cloud add-source forms. Manual namespace edits now preserve in-progress boundary underscores in the UI, while each add flow still canonicalizes the submitted namespace before saving. Also extract the pure namespace helper logic into a small shared module so the underscore regression is covered by a focused Vitest test without pulling in the URL parsing dependency tree. Verification: - bun x vitest run tests/source-identity.test.ts Notes: - A previous attempt to import the helper from the full source-identity module failed locally because that module depends on tldts; the regression test now targets the extracted pure helper module directly.
Right-align the cancel and submit buttons in the inline secret creation forms so the actions sit on the trailing edge of the panel. Also replace the primary button label text from "Create & use" to "Create and use" in both the shared secret-header auth UI and the Google Discovery inline secret form for consistency. Verification: - inspected the updated JSX in the affected components
Prevent object-shaped execution and tool errors from collapsing to [object Object] in the Cloudflare dynamic worker runtime. Preserve normal Error.message behavior, JSON-serialize plain thrown objects, and update the runtime tests to cover both cases. Verified with bun x vitest run in packages/kernel/runtime-dynamic-worker.
@executor/sdk
@executor/plugin-file-secrets
@executor/plugin-google-discovery
@executor/plugin-graphql
@executor/plugin-keychain
@executor/plugin-mcp
@executor/plugin-onepassword
@executor/plugin-openapi
@executor/plugin-workos-vault
commit: |
Contributor
Author
|
Superseded by #244, which redoes this work as a clean refactor from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[object Object]Error.messagebehavior for standard errorsRoot Cause
The dynamic worker runtime formatted execution failures with
err.message ?? String(err). When sandboxed code or a tool failure threw a plain object, that fell through toString(err)and surfaced as[object Object].Validation
cd packages/kernel/runtime-dynamic-worker && bun x vitest run src/invocation.test.ts --reporter=verbosecd packages/kernel/runtime-dynamic-worker && bun x vitest run src/executor.test.ts --reporter=verboseScreenshot Context