Support OpenAPI server variables during onboarding#246
Merged
RhysSullivan merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
Preserve enum and description metadata on server variables through
extraction and preview so the add-source UI can render per-variable
pickers (e.g. Sentry's {region}) and submit a fully resolved base URL
instead of a templated one.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| 🔵 In progress View logs |
executor-cloud | 875f341 | Apr 14 2026, 09:15 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 875f341 | Commit Preview URL Branch Preview URL |
Apr 14 2026, 09:16 PM |
@executor/sdk
@executor/plugin-file-secrets
@executor/plugin-google-discovery
@executor/plugin-graphql
@executor/plugin-keychain
@executor/plugin-mcp
@executor/plugin-onepassword
@executor/plugin-openapi
@executor/plugin-workos-vault
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enumanddescriptionon server variables through extraction + preview (previously we flattened to just thedefault).https://{region}.sentry.io.SpecPreview.serversfromSchema.Array(Schema.Unknown)toSchema.Array(ServerInfo)and exportServerVariable+substituteUrlVariablesfrom the SDK.Why
Specs like Sentry's declare server variables with enums:
Previously the UI stored the literal
https://{region}.sentry.ioas the base URL, which broke requests. Users also had no way to pickdeoverus.Test plan
bunx vitest runinpackages/plugins/openapi(27 passing, incl. new extraction test for Sentry-style{region}with enum + description)bunx turbo run typecheckacross all 28 packages