test(cloud): exercise addSpec on the full Cloudflare spec through real postgres#278
Merged
RhysSullivan merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
…l postgres The adapter regressions the rest of this stack fixes weren't caught by the existing test suite because plugin tests used an in-memory adapter and the cloud-app integration tests only exercised trivial specs. Add one test in the existing node-pool harness (real postgres-js + drizzle + plugin + HTTP) that posts the 16MB Cloudflare fixture through /openapi/specs, asserts >1000 tools land, then removes the source. Depends on two fixes earlier in this stack: - Workers-native fetch + JSON.parse (else parse times out) - drizzle native chunked createMany (else writes time out on PGlite) With both in place the test completes in ~3s locally. Any future regression that reintroduces per-row inserts, a new N+1 on the addSpec/removeSpec path, or parse-side network issues will make this test fail/timeout in the same suite developers already run — no dedicated budget assertion needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adapter regressions the rest of this stack fixes weren't caught by
the existing test suite because plugin tests used an in-memory adapter
and the cloud-app integration tests only exercised trivial specs. Add
one test in the existing node-pool harness (real postgres-js + drizzle
/openapi/specs, asserts >1000 tools land, then removes the source.
Depends on two fixes earlier in this stack:
With both in place the test completes in ~3s locally. Any future
regression that reintroduces per-row inserts, a new N+1 on the
addSpec/removeSpec path, or parse-side network issues will make this
test fail/timeout in the same suite developers already run — no
dedicated budget assertion needed.