mcp: allow saving OAuth2 source before sign-in#364
Merged
RhysSullivan merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
Selecting the OAuth auth method when adding an MCP source no longer
forces the admin to complete the authorization flow before Save. The
source is persisted with `{kind: "oauth2", connectionId}` pointing at
the stable `mcp-oauth2-${namespace}` id, and each user later mints
their own backing connection via McpSignInButton on the source detail
page (per-scope shadowing resolves tokens per-user at invoke time).
On the plugin side, remote addSource now captures resolver failures
(e.g. no connection minted yet, missing header secret) the same way it
already handles discovery failures: the source row still lands in the
catalog so it shows up in the list and exposes a Sign-in affordance,
while the underlying error still surfaces to the caller for logging.
Stdio behaviour is unchanged — a stdio resolver failure is a config
error the admin must fix first.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| 🔵 In progress View logs |
executor-cloud | 5dc4aa8 | Apr 22 2026, 03:46 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 5dc4aa8 | Apr 22 2026, 03:47 AM |
@executor/sdk
@executor/plugin-file-secrets
@executor/plugin-google-discovery
@executor/plugin-graphql
@executor/plugin-keychain
@executor/plugin-mcp
@executor/plugin-oauth2
@executor/plugin-onepassword
@executor/plugin-openapi
@executor/plugin-workos-vault
executor
commit: |
3 tasks
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
McpSignInButton.AddMcpSource.tsx: emit{kind: "oauth2", connectionId}using the stablemcp-oauth2-${namespace}id even when tokens haven't been collected;authReadydrops thetokens !== nullgate so Save is enabled.plugin.ts:addSourcenow wrapsresolveConnectorInputinEffect.eitherfor remote transports — a missing oauth2 connection or unresolvable header secret no longer short-circuits the save. The source lands in the catalog (same pattern as the existing "0 tools when discovery fails" behavior) and the underlying error still surfaces. Stdio resolver failures remain hard-failures.McpSignInButtonalready did the right thing — the missing piece was ensuring the saved source had a non-trivial{kind: "oauth2", connectionId}to drive it.Test plan